Conversation
Documentation says that vendored versions of requests and urllib3 are no longer being used and have been replaced with a direct dependency on upstream urllib3 and requests is no longer a dependency of botocore. https://botocore.amazonaws.com/v1/documentation/api/latest/index.html#upgrading-to-1-11-0 However, the "requests is no longer a dependency of botocore" statement is not true currently, since requests are used in botocore/exceptions.py and in tests. I believe it's time to remove vendored requests.
Codecov Report
@@ Coverage Diff @@
## develop #1817 +/- ##
===========================================
+ Coverage 92.51% 92.54% +0.03%
===========================================
Files 53 53
Lines 9958 9958
===========================================
+ Hits 9213 9216 +3
+ Misses 745 742 -3
Continue to review full report at Codecov.
|
|
Hello @jamesls, |
|
Hi, thanks for the PR. We won't be able to remove the entire requests directory. We want to keep the exceptions in place in order to help with backwards compatibility. Additionally, some of the changes in here won't work as is. For example in the exceptions.py the imports to vendored requests are removed but replaced with a direct dependency on requests (https://github.com/boto/botocore/pull/1817/files#diff-7768fbeb174f209a8fc3ed77a823ac1c). We explicitly do not want to depend on requests (only urllib3) and this won't fix the reason they were left in the first place (to preserve backwards compatibility for people catching those vendored exceptions). To help speed this along, I've gone ahead and added a PR that I think this is a compromise that can make everyone happy:
Let me know if you have any questions or concerns. |
3 participants
Hi everyone,
The documentation says that vendored versions of
requestsandurllib3are no longer being used and have been replaced with a direct dependency on upstreamurllib3andrequestsis no longer a dependency ofbotocore.However, the
requests is no longer a dependency of botocorestatement is not true currently, sincerequestsis used inbotocore/exceptions.pyand in tests.I believe it's time to remove vendored
requests.This PR closes #1122, closes #1608, closes #1615, and closes jantman/awslimitchecker#421.