Backport urllib3 upstream fix for reset connections to AWS servers, fixes #1248#1385
Closed
ezyang wants to merge 1 commit intoboto:developfrom
Closed
Backport urllib3 upstream fix for reset connections to AWS servers, fixes #1248#1385ezyang wants to merge 1 commit intoboto:developfrom
ezyang wants to merge 1 commit intoboto:developfrom
Conversation
…ixes boto#1248 Signed-off-by: Edward Z. Yang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #1385 +/- ##
========================================
Coverage 80.52% 80.52%
========================================
Files 87 87
Lines 12121 12121
========================================
Hits 9760 9760
Misses 2361 2361
Continue to review full report at Codecov.
|
fsmanuel
reviewed
May 29, 2018
| # Don't bother reading the body of a HEAD request. | ||
| # FIXME: Can we do this somehow without accessing private httplib _method? | ||
| self._original_response.close() | ||
| return |
Contributor
|
We have un-vendored requests/urllib3 and are now using urllib3 directly as of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves #1248 in botocore HEAD. The proper fix is to update urllib3 but I don't know why you are vendoring
requestsin the first place.Upstream fix I backported was urllib3/urllib3#1235