fix: Prompt so that commit messages are (way more) consistent#366
fix: Prompt so that commit messages are (way more) consistent#366
Conversation
|
nice! |
|
I think this is probably a good time to filter the commit message for bad characters such as '(' ')' brackets which causes the shell command to fail. we could filter out everything that's not alphanumeric or handle brackets specially... or use string literal input for the shell command function?? |
Yep good point. Added shell escaping. We could go further and enforce conventional. But for now this should cut it well enough. Master is essentially broken :/ |
## 🤖 New release
* `kwaak`: 0.12.0 -> 0.13.0 (⚠ API breaking changes)
### ⚠ `kwaak` breaking changes
```text
--- failure unit_struct_changed_kind: unit struct changed kind ---
Description:
A public unit struct has been changed to a normal (curly-braces) struct, which cannot be constructed using the same struct literal syntax.
ref: rust-lang/cargo#10871
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/unit_struct_changed_kind.ron
Failed in:
struct NoopLLM in /tmp/.tmpPAyx1n/kwaak/src/test_utils.rs:161
```
<details><summary><i><b>Changelog</b></i></summary><p>
<blockquote>
## [0.13.0] - 2025-03-01
### 🚀 Features
- *(agent)* Better task focus with improved summarizer (#365)
### 🐛 Bug Fixes
- Prompt so that commit messages are (way more) consistent (#366)
<!-- generated by git-cliff -->
</blockquote>
</p></details>
---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
2 participants
Tested with claude sonnet and openai 4o and 4o mini with the diff of this PR. Looks good now.