Skip to content

refactor: add missing signal cleanup handlers in view classes#2324

Merged
m3nu merged 1 commit intomasterfrom
fix-destroys
Dec 18, 2025
Merged

refactor: add missing signal cleanup handlers in view classes#2324
m3nu merged 1 commit intomasterfrom
fix-destroys

Conversation

@m3nu
Copy link
Contributor

@m3nu m3nu commented Dec 17, 2025

  • Add _on_destroyed cleanup for global signal connections to prevent potential crashes after widget destruction
  • Fix translation format bug in main_window.py (move .format() outside tr())
  • Move prune signal connections from populate_from_profile() to init in archive_tab.py to prevent duplicate connections

Files with new cleanup handlers:

  • networks_page.py, log_page.py, shell_commands_page.py

Files with extended cleanup handlers:

  • repo_tab.py, source_tab.py, schedule_tab.py, schedule_page.py

- Add _on_destroyed cleanup for global signal connections to prevent
  potential crashes after widget destruction
- Fix translation format bug in main_window.py (move .format() outside tr())
- Move prune signal connections from populate_from_profile() to __init__
  in archive_tab.py to prevent duplicate connections

Files with new cleanup handlers:
- networks_page.py, log_page.py, shell_commands_page.py

Files with extended cleanup handlers:
- repo_tab.py, source_tab.py, schedule_tab.py, schedule_page.py
@m3nu m3nu merged commit e112e80 into master Dec 18, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant