Thanks for the fix. The right thing to skip this conditionally. I do wonder why tests aren't failing on Github. Much of the output is already mocked. Maybe due to different versions used somewhere.

Ya know I was curious about why it wasn't failing in the Github tests too, and so I just looked into it a bit, and pretty sure it's becuase we're just not running this test at all in the Github actions. Looks like the Actions explicitly run make test-unit and make test-integration, but this test (and one other for NetworkManager) are a secret third category of tests, network_manager, which doesn't have a corresponding Makefile command.

I wonder if the Github runners even have enough of a desktop environment to have the network_manager tests even do anything, come to think of it. May be worth a shot though, I guess.

That's likely the reason. The network tests didn't work on GH so they put them separately. You can still run them locally with uv run pytest tests/... Can you add the skipping to both. Like this:

For test_darwin.py (macOS only):

import sys
pytestmark = pytest.mark.skipif(sys.platform != 'darwin', reason="macOS only")

For test_network_manager.py (Linux only):

import sys
pytestmark = pytest.mark.skipif(sys.platform != 'linux', reason="Linux only")

This applies the skip condition to all tests in the file automatically. When you run tests on the wrong platform, pytest will skip the entire file with the reason displayed. Source