Fix the blank entry in the Custom exclusion#2268
Merged
m3nu merged 2 commits intoborgbase:masterfrom Aug 19, 2025
Merged
Conversation
Collaborator
Author
|
Also included a fix for the issue #2134 BUG: Does not exist error due to missing DB entry.
|
m3nu
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the blank item that was getting added in the Custom tab of the Exclusion dialog. Even though the blank entry was getting discarded in GUI, it stayed when reopening the dialog. The reason being, the item was added to the database as a blank entry right when it was created.
A condition check was added to check if the entry is not blank before adding to the database.
Related Issue
Fixes #2267
Fixes #2134 (Unrelated bug fix)
How Has This Been Tested?
The fix has been tested with the GUI.
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.