As of right now I have two UI design concepts, it would be great to have some feedback

First one is this, adding two separate buttons, Exclude File to open the file dialog and Exclude Pattern to add one pattern at a time (functions same as the current plus button).

Second one has a single plus button having a submenu with two choices as mentioned above, a lot cleaner on UI front but adds an extra click (for every pattern you manually add).

First option seems better since we have enough space and it's more explicit.

By keeping the + button as it is, this is the current design:

Now for the button text other options I can think of is

• Browse Exclusions
• Browse Exclusion Files
• Select Files and Folders to Exclude (seems too long)
• Add Exclusions
• Choose Exclusion Files
• Select Exclusion Files

Making that + button into named button as shown in my previous comment left the - button looking out of place and changing the - button to a named button will further increase the overall button width in the dialog. Would love to have some feedback on this.

I'm starting on the implementation since the layout design has already been fixed (only the button label mentioned above can change, if needed).

Looks good to me.

I have added the last few changes, works fine during testing, both files and folders given are being excluded as expected.

(rebased)

I would test for blank strings as well s.strip() == ‘’ under text_editing_finished() just to be complete #2260

Also fixes #2260

Excluding this pattern and a specific folder isn't the same. When a user selects a specific folder they would expect the exclusion to only apply to this one folder, not all with the same name.

Here a minimal reproducible example of the issue:

Given this source folder
~

And this excluded folder line
fm:*/Downloads

which was selected in the UI as ~/Downloads

I have these folders and files:
~/Downloads
~/Desktop/Downloads/important vorta file.png
And only want to exclude ~/Downloads, but never had the intention to exclude ~/Desktop/Downloads and the important file in it.

Unfortunately after testing the feature I can confirm that both folders are excluded, which isn't the user's intention and very unexpected.

I have changes the pattern from fm: to pf:

This pattern style is (only) useful to match full paths. This is kind of a pseudo pattern as it can not have any variable or unspecified parts - the full path must be given. pf:root/file.ext matches root/file.ext only. A leading path separator is always removed.

I have tested out the same and now it should work as expected. Also the wildcard path have been replaced with complete path of file/folder selected, as required by the pf: pattern.