Merged
Conversation
add links for - donating - contributing - source code - faq
satisfy the linter I: com.borgbase.Vorta:7: developer-id-missing
Contributor
Author
|
the url to transifex is broken? |
Collaborator
|
Yeah seems like it, its has been a few days. It says the page doesn't exist when you follow that link. |
m3nu
previously approved these changes
Jun 12, 2025
Contributor
m3nu
left a comment
m3nu
left a comment
There was a problem hiding this comment.
Nice cleanup. Thanks a lot!
Contributor
|
Our test tool doesn't know some of those tags. Should we ignore anything that's not an error? |
Contributor
Author
I'm guessing this is because of the old 22.04 runner that ships an older version of appstreamcli that simply doesn't have these properties yet. |
Contributor
Makes sense. Let's try bumping the runner version. |
m3nu
approved these changes
Jun 14, 2025
Contributor
|
Nice addition. Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this adds a bunch of missing metadata like faq, donation links, dev id etc.
and up-to-date screenshots
mostly according to https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/quality-guidelines
Related Issue
Motivation and Context
new screenshots present what the app actually is
people will be more likely to donate/contribute if you give them easier access to the links
How Has This Been Tested?
appstreamcli validate com.borgbase.Vorta.appdata.xmlScreenshots (if appropriate):
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.