Add a new unified file selector#2237
Merged
m3nu merged 10 commits intoborgbase:masterfrom Jun 4, 2025
Merged
Conversation
Collaborator
Author
|
This is how the final implementation looks like:
|
Contributor
|
Looks great! Good job! Will be a useful addition to be used in several places in Vorta. I would still look into those things:
|
Collaborator
Author
|
I've include both changes. Now the window and sub-title can be passed as arguments, also cleaned up the base class a bit. |
m3nu
approved these changes
Jun 4, 2025
Contributor
|
Good job, @VandalByte! More consistent than before. There is still an issue with hanging macOS tests, which I'll debug later. Likely due to some type of access confirmation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, in Vorta, we use two separate file selectors for selecting files and folders due to limitations in Qt. This PR introduces a unified file selector made with
QTreeViewthat:Related Issue
Solves #1869
Motivation and Context
Due to limitations in the Qt, we previously had to rely on separate dialogs for files and folders, which created a confusing and less efficient user experience. This PR improves usability and code maintainability by replacing them with a new single selector.
How Has This Been Tested?
As of now, manual UI testing has been performed to verify the new selector works as expected. Existing test cases may currently fail due to new changes. These will be fixed accordingly. Additional tests will be added to cover the new functionality.
Screenshots (if appropriate):
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.