Skip to content

add exclude patterns for most common media files and .part files#2145

Merged
m3nu merged 5 commits intoborgbase:masterfrom
renner0e:exclude
Dec 30, 2024
Merged

add exclude patterns for most common media files and .part files#2145
m3nu merged 5 commits intoborgbase:masterfrom
renner0e:exclude

Conversation

@renner0e
Copy link
Contributor

@renner0e renner0e commented Nov 20, 2024 •
edited
Loading

adds more exclusion presets related to media files, video and audio.
No picture formats because they were not added the originally

Does it make sense to split them up in music, video and images in the future?
Possibly make a new file for just media formats as they are now in dev.json

Description

Related Issue

Motivation and Context

How Has This Been Tested?

I did not test anything
json is valid

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.

m3nu
m3nu previously approved these changes Dec 5, 2024
View reviewed changes
@m3nu
Copy link
Contributor

m3nu commented Dec 5, 2024

Thanks for the contribution! Wanna move them to a separate file and make the groups you suggested? Could be nice, I think. dev was imagined for code tools, git cache and such.

@m3nu m3nu dismissed their stale review December 5, 2024 13:59

good suggestion to add separate file. Like media.json?

@renner0e
Copy link
Contributor Author

renner0e commented Dec 28, 2024 •
edited
Loading

Thanks for the contribution! Wanna move them to a separate file and make the groups you suggested? Could be nice, I think. dev was imagined for code tools, git cache and such.

Should I do that in this PR or in a later PR?
I'd prefer to do that in a separate PR

Did you intend to make a merge commit on my branch? Instead of merging it into main branch?

@m3nu
Copy link
Contributor

m3nu commented Dec 28, 2024

I would do it in the same PR, since it's a small change.

I've rebased your branch to include the latest changes.

@renner0e renner0e requested a review from m3nu December 28, 2024 20:33
m3nu
m3nu approved these changes Dec 28, 2024
View reviewed changes
Copy link
Contributor

@m3nu m3nu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@m3nu
Copy link
Contributor

m3nu commented Dec 28, 2024

Thanks for the change and contribution. Looks all good. Anything to add before merging?

@renner0e
Copy link
Contributor Author

renner0e commented Dec 28, 2024

Thanks for the change and contribution. Looks all good. Anything to add before merging?

It's fine

@m3nu m3nu merged commit 9836458 into borgbase:master Dec 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m3nu m3nu m3nu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@renner0e @m3nu