Skip to content

Fix generic window icon on Wayland#2068

Merged
m3nu merged 1 commit intoborgbase:masterfrom
Parnassius:wayland-icon
Sep 6, 2024
Merged

Fix generic window icon on Wayland#2068
m3nu merged 1 commit intoborgbase:masterfrom
Parnassius:wayland-icon

Conversation

@Parnassius
Copy link
Contributor

Fix the main window icon on Wayland

Description

On Wayland, calling setWindowIcon() to set the window icon is no longer supported, the correct way is to call setDesktopFileName() instead. The desktop file is then used to load the correct icon.

See https://doc.qt.io/qt-6/qguiapplication.html#desktopFileName-prop and https://community.kde.org/Guidelines_and_HOWTOs/Wayland_Porting_Notes#Application_Icon for more information.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Before:
image

After
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.

@m3nu
Copy link
Contributor

m3nu commented Sep 1, 2024

Useful change. I see the mac tests timed out, which is likely due to a Github CI issue.

@m3nu m3nu self-assigned this Sep 1, 2024
@m3nu m3nu merged commit 00fa34a into borgbase:master Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants