Skip to content

palette_changed connection moved to schedule_tab#2050

Merged
m3nu merged 1 commit intoborgbase:masterfrom
shivansh02:issue2048
Aug 6, 2024
Merged

palette_changed connection moved to schedule_tab#2050
m3nu merged 1 commit intoborgbase:masterfrom
shivansh02:issue2048

Conversation

@shivansh02
Copy link
Collaborator

Description

Moved palette_changed connection from schedule_page.py to schedule_tab.py, where set_icons() is defined.

Related Issue

Resolves #2048

Motivation and Context

How Has This Been Tested?

Could not test as changing themes does not work on my system.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.

@shivansh02 shivansh02 requested a review from m3nu August 2, 2024 10:46
@abhiaagarwal
Copy link

Built this branch and successfully triggered dark mode on/off in foreground and background with no issues.

@m3nu m3nu merged commit 55822ab into borgbase:master Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vorta freezes in background on MacOS from master branch

3 participants