Merged
Conversation
Collaborator
real-yfprojects
left a comment
real-yfprojects
left a comment
There was a problem hiding this comment.
Thanks for this nice addition!
shivansh02
force-pushed
the
feature/compaction-scheduling
branch
from
3b5bcbb to
277b9b9
Compare
Collaborator
Author
|
@m3nu All checks passed, can we merge this now? |
shivansh02
force-pushed
the
feature/compaction-scheduling
branch
from
277b9b9 to
d89b832
Compare
m3nu
requested changes
Jun 28, 2024
src/vorta/store/models.py
Outdated
| schedule_make_up_missed = pw.BooleanField(default=True) | ||
| validation_on = pw.BooleanField(default=True) | ||
| validation_weeks = pw.IntegerField(default=3) | ||
| compaction_on = pw.BooleanField(default=True) |
Contributor
There was a problem hiding this comment.
Let's disable it by default to avoid surprising behavior.
shivansh02
force-pushed
the
feature/compaction-scheduling
branch
from
d89b832 to
bd0433a
Compare
m3nu
approved these changes
Jun 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows users to run
borg compactafter specified intervals. Added 2 columns to the profile model:compaction_onto check/uncheck scheduling, andcompaction_weeksto set interval in weeks. Default interval set to 3 weeks.Related Issue
Resolves #1718
Motivation and Context
Backup space usage is exploding for some people until they realize they have to run compact manually. This allows users to schedule running compact just like validation.
How Has This Been Tested?
Tested manually by setting
compaction_cutoffto minutes instead of days inscheduler.py.Screenshots (if appropriate):
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.