Improved Exception Dialog with Copy Paste#1977
Conversation
diivi
left a comment
diivi
left a comment
There was a problem hiding this comment.
Looks like a nice improvement over the error dialog that we have currently, thanks!
src/vorta/views/exception_dialog.py
Outdated
| def get_os_details(): | ||
| uname_result = platform.uname() | ||
| os_details = f"OS: {uname_result.system}\n" | ||
| os_details += f"Node Name: {uname_result.node}\n" |
There was a problem hiding this comment.
Not sure if this is necessary.
Looks good for me too otherwise:
There was a problem hiding this comment.
Maybe use a format string for the datetime, so it doesn't put the subsecond decimals there.
About the "Log:":
- that's a traceback and guess you did not get it from the log, but directly within python.
- but, vorta (and also borg) do write a log, which might have some additional interesting infos, which you do not yet include. maybe a link that opens the correct log file so that the user can easily c&p stuff from there would be useful here.
|
I suppose |
|
@m3nu @ThomasWaldmann Can you please take a look? |
This can be done once this is merged. |
src/vorta/assets/icons/alert.svg
Outdated
There was a problem hiding this comment.
Where did you source this image from?
There was a problem hiding this comment.
There was a problem hiding this comment.
If I understand correctly the image file is released into the public domain and we are free to relicence it?
We should also consider using the corresponding fork awesome icon for consistency with the other icons in the GUI.
|
Needs rebase and an icon from the sources we usually use https://vorta.borgbase.com/contributing/#icons |
shivansh02
force-pushed
the
feature/improved-exception-box-with-copy-paste
branch
from
20f68fb to
422973f
Compare
@m3nu Done, and the checks are passing as well. Can we merge this? |
shivansh02
force-pushed
the
feature/improved-exception-box-with-copy-paste
branch
from
422973f to
7ce0dfd
Compare
m3nu
force-pushed
the
feature/improved-exception-box-with-copy-paste
branch
from
7ce0dfd to
df196d8
Compare
5 participants
Description
Exception dialog improvements:
-better UI
-copy paste functionality
-detailed error with system information
-report to github functionality
Related Issue
Fixes #1861
Motivation and Context
Exception Dialog currently has bad UI and no copy paste functionality.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.