Skip to content

Add some more exclusion presets#1970

Merged
m3nu merged 16 commits intoborgbase:masterfrom
SAMAD101:expatex
Apr 6, 2024
Merged

Add some more exclusion presets#1970
m3nu merged 16 commits intoborgbase:masterfrom
SAMAD101:expatex

Conversation

@SAMAD101
Copy link
Collaborator

@SAMAD101 SAMAD101 commented Mar 16, 2024 •
edited
Loading

Description

Added some exclusions that could be useful for some users.

Related Issue

#907

Motivation and Context

Would make it a lot easier to exclude these files/directories.

Screenshots (if appropriate):

Screenshot_20240317_025208

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.

@shivansh02
Copy link
Collaborator

shivansh02 commented Mar 16, 2024

Adding spotify seems too specific imho. This way we'll end up including patterns for a lot of apps.
Also can you include docker build cache in this? I think its stored in /var/lib/docker.

@SAMAD101
Copy link
Collaborator Author

SAMAD101 commented Mar 17, 2024 •
edited
Loading

Adding spotify seems too specific imho. This way we'll end up including patterns for a lot of apps.
Also can you include docker build cache in this? I think its stored in /var/lib/docker.

Well, Spotify is something a lot of people use and it's cache gets quite big with time so, i considered it.

Sure, I can add Docker build cache as well.

@SAMAD101
Copy link
Collaborator Author

SAMAD101 commented Mar 17, 2024 •
edited
Loading

@shivansh02 Though adding val/lib/docker won't matter much Vorta can't run root backups as of now anyway.

@real-yfprojects real-yfprojects changed the title Exclusion patterns expansion Add some more exclusion presets Apr 1, 2024
@real-yfprojects
Copy link
Collaborator

real-yfprojects commented Apr 1, 2024

Adding spotify seems too specific imho. This way we'll end up including patterns for a lot of apps.

At some point we might want to merge multiple apps into one preset. E.g. all desktop apps, all script languages, ...
Or we might want to extract the patterns to independent repository so that other apps can use the data as well.

@real-yfprojects real-yfprojects requested a review from m3nu April 1, 2024 14:09
@m3nu m3nu merged commit 58137f0 into borgbase:master Apr 6, 2024
@SAMAD101 SAMAD101 deleted the expatex branch April 7, 2024 18:47
shivansh02 pushed a commit to TheLazron/vorta that referenced this pull request Jun 7, 2024
@SAMAD101 @shivansh02
Add new exclusion presets (borgbase#1970)
7782683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m3nu m3nu m3nu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SAMAD101 @shivansh02 @real-yfprojects @m3nu