Notify after post_backup_tasks #1632#1940
Merged
m3nu merged 4 commits intoborgbase:masterfrom Apr 7, 2024
Merged
Conversation
Contributor
Author
|
@m3nu @real-yfprojects please check this out |
Collaborator
real-yfprojects
left a comment
There was a problem hiding this comment.
Thank you for your work! Please find minor notes below.
real-yfprojects
approved these changes
Apr 7, 2024
shivansh02
pushed a commit
to TheLazron/vorta
that referenced
this pull request
Jun 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Made changes to notify function to deliver notifications based on the status of post_backup_tasks. Post Backup Tasks include pruning as well as BorgCheckJob(data consistency check) as referred to in the issue. This way user isnt spammed with different notifications and still notified for post backup jobs
Related Issue
Fixes #1632
Motivation and Context
A notification for when post backup jobs were completed, earlier only a log for completion of these jobs was delivered. Now a status based notification is delivered
How Has This Been Tested?
Backups were scheduled and after completion of post_backup_jobs expected notifications were delivered.
Screenshots (if appropriate):
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.