Skip to content

Notify after post_backup_tasks #1632#1940

Merged
m3nu merged 4 commits intoborgbase:masterfrom
TheLazron:check-notification-#1632
Apr 7, 2024
Merged

Notify after post_backup_tasks #1632#1940
m3nu merged 4 commits intoborgbase:masterfrom
TheLazron:check-notification-#1632

Conversation

@TheLazron
Copy link
Contributor

@TheLazron TheLazron commented Feb 21, 2024

Description

Made changes to notify function to deliver notifications based on the status of post_backup_tasks. Post Backup Tasks include pruning as well as BorgCheckJob(data consistency check) as referred to in the issue. This way user isnt spammed with different notifications and still notified for post backup jobs

Related Issue

Fixes #1632

Motivation and Context

A notification for when post backup jobs were completed, earlier only a log for completion of these jobs was delivered. Now a status based notification is delivered

How Has This Been Tested?

Backups were scheduled and after completion of post_backup_jobs expected notifications were delivered.

Screenshots (if appropriate):

WhatsApp Image 2024-02-22 at 00 31 18

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.

@TheLazron TheLazron marked this pull request as ready for review February 23, 2024 10:38
@TheLazron
Copy link
Contributor Author

@m3nu @real-yfprojects please check this out

Copy link
Collaborator

@real-yfprojects real-yfprojects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work! Please find minor notes below.

@m3nu m3nu merged commit 3268bf1 into borgbase:master Apr 7, 2024
shivansh02 pushed a commit to TheLazron/vorta that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FR: Notifications for consistency check

3 participants