Disabled "Collapse" button in "Flat" view#1855
Merged
real-yfprojects merged 3 commits intoborgbase:masterfrom Apr 1, 2024
Merged
Disabled "Collapse" button in "Flat" view#1855real-yfprojects merged 3 commits intoborgbase:masterfrom
real-yfprojects merged 3 commits intoborgbase:masterfrom
Conversation
Contributor
Author
|
@real-yfprojects Can you review this PR? |
real-yfprojects
approved these changes
Dec 8, 2023
Collaborator
|
Sorry for the delay @AdwaitSalankar. Glad this fix is merged now! |
shivansh02
pushed a commit
to TheLazron/vorta
that referenced
this pull request
Jun 7, 2024
Our `DiffResultDialog` and `ExtractDialog` show a context menu for items of the list/tree view. The collapse action in this menu only makes sense for the tree mode of the view. This commit therefore enables the option only for this view mode. * src/vorta/views/extract_dialog.py * src/vorta/views/diff_result.py * tests/unit/test_diff.py : Add tests for the new behaviour. * tests/unit/test_extract.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Used
setEnabledto disablebCollapseAllin flat mode and enabled it in the other modes.Related Issue
Fixes #1784
How Has This Been Tested?
Wrote tests for the behaviour in
test_extract.pyandtest_diff.pyTypes of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.