feat: Added change passphrase dialog#1659
feat: Added change passphrase dialog#1659jetchirag wants to merge 14 commits intoborgbase:masterfrom
Conversation
Signed-off-by: Chirag Aggarwal <[email protected]>
|
I was thinking that we could use a common widget (a self-implemented one) for all password entries in vorta. Can you implement such thing? |
|
@real-yfprojects I am assuming password marking, visibility toggle and validation etc in the widget. Should I subclass QLineEdit? |
|
No, I wouldn't do that you can subclass QWidget and add a layout with the widgets. |
|
Okay I'll open a new PR for widget after closing this. |
Signed-off-by: Chirag Aggarwal <[email protected]>
|
I've added 2 new tests but currently the test repo doesn't have encryption so it would run mock command on non-encrypted repo. I can add another repo but it doesn't seem necessary since in GUI button is disabled. |
Co-authored-by: yfprojects <[email protected]>
Co-authored-by: yfprojects <[email protected]>
Signed-off-by: Chirag Aggarwal <[email protected]>
Signed-off-by: jetchirag <[email protected]>
Signed-off-by: jetchirag <[email protected]>
Co-authored-by: yfprojects <[email protected]>
Signed-off-by: Chirag Aggarwal <[email protected]>
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
This can now be updated to use the new widgets you implemented @jetchirag |
Signed-off-by: Chirag Aggarwal <[email protected]>
Signed-off-by: Chirag Aggarwal <[email protected]>
real-yfprojects
left a comment
real-yfprojects
left a comment
There was a problem hiding this comment.
Almost ready to be merged!
Currently the dialog has Vorta as a window title. This should be something like Change Encryption Passphrase. I think we no longer need the 'title' label then.
Signed-off-by: Chirag Aggarwal <[email protected]>
|
Done ✅ |
|
Just noticed merge conflict. Will solve them. |
| # def validate(self): | ||
| # """Check encryption type""" | ||
| # if self.profile.repo.encryption.startswith('repokey'): | ||
| # return True | ||
| # self.errorText.setText(translate('utils', 'Encryption type must be repokey.')) | ||
| # return False |
There was a problem hiding this comment.
Dead code, Is this still needed?
2 participants
Description
A way to change the password I provided when the repo were created.
Related Issue
Fixes #303
How Has This Been Tested?
Manually tested with local repos. Pending more extensive testing.
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.