Skip to content

Blank entry for unchecked item in Custom pattern Exclusion tab #2267

@VandalByte

Description

@VandalByte

Description

I encountered this issue while I was working on another issue and I have also mentioned that there.

What is happening is if an unchecked item is added in the Custom tab of the Exclusion dialog of Vorta. Then if you give a blank entry and just close the dialog, when you reopen the Exclusion dialog you will see a blank entry at the top.

Image

The expected behavior is that the item shouldn't be added to the list at all, it should be discarded. So from my testing the issue only exists for the unchecked items and for the checked items everything works as expected.

I was able to reproduce the issue.

Steps to reproduce the behavior:

  1. Go and open up the exclusion dialog and go to Custom tab.
  2. Click on the plus button to add a new item.
  3. Uncheck the item and just close the dialog.
  4. When you reopen the dialog again, you should see a new blank entry at the top as shown in the image.

Environment

  • OS: Linux (MX Linux 23)
  • Vorta version: 0.10.3
  • Installed from: Github (source)
  • Borg version: 1.4.0

Logs

Nothing interesting in the logs

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueSimple change to start learning code base

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions