-
Notifications
You must be signed in to change notification settings - Fork 180
Description
Description
Creating a new profile adds the new profile at the bottom of the list in the main window. Similarly, editing an existing profile doesn't change its position in the list. I think that in both cases the list should be kept sorted. Restarting Vorta correctly updates the positions of the profiles to be sorted alphabetically.
This was recently noticed during the review of #1899 (comment)
Steps to reproduce the behavior:
- Create a new profile using the menu in the main window
- The profile is added last on the list, even if it should sort before other entries
Alternatively:
- Rename an already existing profile
- Its position in the list doesn't change, even if the new alphabetical ordering is no longer valid
Environment
- OS: Linux
- Vorta version: latest commit (9b8dbce)
- Installed from: pip
- Borg version: N/A
I see two possible solutions for this:
-
Add some additional handling in the
profile_add_edit_resultfunction to keep the list sorted. This is a quick commit that does that: Parnassius@59661f9 -
Use the sortItems method of QListWidget to sort the list after every update, thus removing the need to use the
order_bysql method.
The two solutions cannot co-exist since the sql ordering is case-insensitive while QListWidget.sortItems is case-sensitive. In the second case additional care should be taken to ensure the use of sortItems doesn't break anything. From a quick glance I think the way current_profile is set during the initialization of the main window should be updated, and maybe some additional changes are needed as well.
vorta/src/vorta/views/main_window.py
Lines 66 to 68 in 9b8dbce
| self.current_profile = BackupProfileModel.get_or_none(id=prev_profile_id.str_value) | |
| if self.current_profile is None: | |
| self.current_profile = BackupProfileModel.select().order_by('name').first() |
What do you think? Let me know if I should create a small pull request with the commit linked above or if a solution based on option 2 should be preferred