Current coverage is 83.77%

Merging #981 into master will decrease coverage by 0.87%

1. 8 files (not in diff) in borg were modified. more
   • Misses +31
   • Partials +11
   • Hits -182
2. File borg/helpers.py was modified. more
   • Misses -1
   • Partials -2
   • Hits +9
3. File ...org/platform_base.py (not in diff) was deleted. more

@@             master       #981   diff @@
==========================================
  Files            17         17          
  Lines          5153       5064    -89   
  Methods           0          0          
  Messages          0          0          
  Branches        919        908    -11   
==========================================
- Hits           4362       4242   -120   
- Misses          571        596    +25   
- Partials        220        226     +6   

Powered by Codecov. Last updated by b8303a3...ddb07ac

I think this should use __slots__ = ("_dict",); not for performance reasons, but to avoid setting invalid attributes that would silently fail to serialize via setattr and it's syntactic sugar:

>>> from borg.item import Item
>>> item = Item()
>>> item.some_invalid_key = 1234
>>> serialized = item.as_dict()
>>> serialized
{}

vs

>>> from borg.item import Item
>>> item = Item()
>>> item.some_invalid_key = 1234
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'Item' object has no attribute 'some_invalid_key'

ok, good idea.

merge? this is isolated, so should be no problem.

Just need to remember that we still have to do the actual refactoring :)