WIP: implement msgpack wrapper so that bytes and str roundtrip#973
Closed
ThomasWaldmann wants to merge 5 commits intoborgbackup:masterfrom
Closed
WIP: implement msgpack wrapper so that bytes and str roundtrip#973ThomasWaldmann wants to merge 5 commits intoborgbackup:masterfrom
ThomasWaldmann wants to merge 5 commits intoborgbackup:masterfrom
Conversation
msgpack has bad defaults and using them made it necessary to have ugly b'keyname' and .encode/.decode all over the place. TODO: key and remote module
they also show where old and new code are compatible and where not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note: i am working on a different approach in another PR (refactor item), this PR is not going to be used as is due to compatibility issues. Some parts of it (like msg_pack.py) might be useful in a slightly modified form, though.
msgpack has bad defaults and using them made it necessary to
have ugly b'keyname' and .encode/.decode all over the place.