implement unix domain socket support#7615
Merged
ThomasWaldmann merged 3 commits intoborgbackup:masterfrom Jun 6, 2023
Merged
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #7615 +/- ##
==========================================
+ Coverage 82.89% 83.85% +0.95%
==========================================
Files 66 66
Lines 11748 11802 +54
Branches 2120 2140 +20
==========================================
+ Hits 9739 9896 +157
+ Misses 1433 1342 -91
+ Partials 576 564 -12
|
ThomasWaldmann
force-pushed
the
serve-socket2
branch
3 times, most recently
from
9c94bfe to
a2f4d60
Compare
Member
Author
|
hmm, the windows CI seems to hang. is this a borg or a github issue? Update: Logs after killing the workflow run: Same thing for the other socket test: Same for the permissions test: So it seems to hang infinitely there, but only on win32. Update: code works on windows cygwin without hanging. @RayyanAnsari can you have a look? |
Contributor
It's not not very common for a GitHub workflow to hang, but I've seen it before. GitHub will kill it after 6 hours runtime. You can either wait or cancel it manually, then restart the workflow - if it hangs again it might be an issue with Borg. The logs of the hanging step might be lost though. |
ThomasWaldmann
force-pushed
the
serve-socket2
branch
2 times, most recently
from
ef734c3 to
4238f10
Compare
ThomasWaldmann
force-pushed
the
serve-socket2
branch
from
4238f10 to
0b9d0ac
Compare
ThomasWaldmann
force-pushed
the
serve-socket2
branch
from
0b9d0ac to
c537cc8
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| def serve_socket(monkeypatch): | ||
| have_a_short_runtime_dir(monkeypatch) | ||
| # use a random unique socket filename, so tests can run in parallel. | ||
| socket_file = tempfile.mktemp(suffix=".sock", prefix="borg-", dir=get_runtime_dir()) |
Check failure
Code scanning / CodeQL
Insecure temporary file
ThomasWaldmann
force-pushed
the
serve-socket2
branch
2 times, most recently
from
1175056 to
7db5a94
Compare
server (listening) side: borg serve --socket # default location borg serve --socket=/path/to/socket client side: borg -r socket:///path/to/repo create ... borg --socket=/path/to/socket -r socket:///path/to/repo ... served connections: - for ssh: proto: one connection - for socket: proto: many connections (one after the other) The socket has user and group permissions (770). skip socket tests on win32, they hang infinitely, until github CI terminates them after 60 minutes. socket tests: use unique socket name don't use the standard / default socket name, otherwise tests running in parallel would interfere with each other by using the same socket / the same borg serve process. write a .pid file, clean up .pid and .sock file at exit add stderr print for accepted/finished socket connection
shutting down logging is problematic as it is global and we do multi-threaded execution, e.g. in tests. thus, rather just flush the important loggers and keep them alive.
ThomasWaldmann
force-pushed
the
serve-socket2
branch
from
af81e71 to
ae97584
Compare
snorkelopstesting2-coder
pushed a commit
to snorkel-marlin-repos/borgbackup_borg_pr_7615_6b6b69c5-9cc9-47d1-8e51-ce2c48caa8d4
that referenced
this pull request
Oct 22, 2025
Original PR #7615 by ThomasWaldmann Original: borgbackup/borg#7615
snorkelopstesting4-web
added a commit
to snorkel-marlin-repos/borgbackup_borg_pr_7615_6b6b69c5-9cc9-47d1-8e51-ce2c48caa8d4
that referenced
this pull request
Oct 22, 2025
Merged from original PR #7615 Original: borgbackup/borg#7615
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server side (listening side):
Client:
BORG_RUNTIME_DIRenv var can be used to overrideBORG_BASE_DIRandplatformdirs.user_runtime_dir, as usual.fixes #6183.