Skip to content

remove nonce management, related repo methods#7556

Merged
ThomasWaldmann merged 1 commit intoborgbackup:masterfrom
ThomasWaldmann:kill-nonce-manager
May 11, 2023
Merged

remove nonce management, related repo methods#7556
ThomasWaldmann merged 1 commit intoborgbackup:masterfrom
ThomasWaldmann:kill-nonce-manager

Conversation

@ThomasWaldmann
Copy link
Member

not needed for borg2 repos (we derive a new session key for each borg invocation and start counting from 0).

also not needed for borg 1.x repos because we only read them (borg transfer) and won't write new encrypted data to them.

not needed for borg2 repos (we derive a new session key for each borg
invocation and start counting from 0).

also not needed for borg 1.x repos because we only read them (borg transfer)
and won't write new encrypted data to them.
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2023

Codecov Report

Merging #7556 (e02d9ed) into master (49fe6f3) will decrease coverage by 0.57%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #7556      +/-   ##
==========================================
- Coverage   83.81%   83.25%   -0.57%     
==========================================
  Files          67       66       -1     
  Lines       11857    11751     -106     
  Branches     2164     1865     -299     
==========================================
- Hits         9938     9783     -155     
- Misses       1343     1381      +38     
- Partials      576      587      +11     
Impacted Files Coverage Δ
src/borg/remote.py 81.11% <ø> (-0.15%) ⬇️
src/borg/repository.py 83.12% <ø> (-0.08%) ⬇️
src/borg/crypto/key.py 88.53% <100.00%> (-0.04%) ⬇️

... and 20 files with indirect coverage changes

@ThomasWaldmann ThomasWaldmann merged commit b70cefa into borgbackup:master May 11, 2023
@ThomasWaldmann ThomasWaldmann deleted the kill-nonce-manager branch May 11, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants