cache.py: be less verbose during cache sync#7277
cache.py: be less verbose during cache sync#7277ThomasWaldmann merged 3 commits intoborgbackup:masterfrom
Conversation
ThomasWaldmann
left a comment
ThomasWaldmann
left a comment
There was a problem hiding this comment.
Thanks for the PR!
We could improve consistency of wording a bit, while we are at it. When I wrote this, I seemed to be undecided about chunks cache vs. chunks index, but guess the latter describes it better.
A small nitpick about "...": when I used this, it wanted to indicate that there is something ongoing after this (usually either followed by some lines of further infos while it is progressing and/or terminated by some "Done." when it is finished).
Maybe either keep that or terminate the sentence with a ".".
Codecov Report
@@ Coverage Diff @@
## master #7277 +/- ##
=======================================
Coverage 83.42% 83.42%
=======================================
Files 67 67
Lines 11582 11585 +3
Branches 2102 2103 +1
=======================================
+ Hits 9662 9665 +3
Misses 1363 1363
Partials 557 557
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Let me know how the latest commit looks. I left the initial "..." to pair with the final "done". |
|
Much better consistency. But some places now say "cache index", that should be also "chunks index". That master |
|
Hopefully I've got it right now! |
|
Thanks! |
3 participants
As discussed in #7271, this makes borg2 less verbose when it is syncing the cache. (This only happens if you access a repository from multiple hosts.) Below is how the new output looks with
-vand with--debug. (With neither, there is no relevant output.)I'd also be ok with showing less with
-vif people prefer. Note that I removed a few places with...in the output to make it look tidier, but I can reverse those.