Codecov Report

Merging #4422 into master will decrease coverage by 0.16%.
The diff coverage is 61.29%.

@@            Coverage Diff             @@
##           master    #4422      +/-   ##
==========================================
- Coverage   84.24%   84.08%   -0.17%     
==========================================
  Files          37       37              
  Lines        9509     9538      +29     
  Branches     1582     1589       +7     
==========================================
+ Hits         8011     8020       +9     
- Misses       1049     1061      +12     
- Partials      449      457       +8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42ea069...4858030. Read the comment docs.

From a short look this looks good.

I'd prefer not to write to config for non critical operations. But that would complicate the code a lot. But if users are going to check a repo there might actually be some storage breakage which this could make even worse. (one way to do that would be to have an auxiliary file that is like config and that stores all keys outside of a manually maintained critical set)

True.

But otoh the only really critical thing in the config is the key (in repokey modes) and we advise to have a key backup.

Also, the config is not directly overwritten, but first written to a tmp name and then renamed over the previous config (plus some syncs).

Yes they are both true. But i think i explicitly ruled out using config for nounce because i wanted to avoid having frequently changing information in config.

And yes, that key is primarily what we want to protect. And maybe the structure so borg still recognizes the directory are repo.

I'm merging this as is now and will open a ticket about separating config into 2.

see #4428.