fix(composables): use shallowRef to prevent reactive component warning #2930
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Fixes Vue warning "Component was made a reactive object" when passing custom components to
useModal,useToast, orusePopovercomposables.Root cause:
toRef()makes objects deeply reactive, including anycomponentproperty.Fix: Replace
toRef(obj)withisRef(obj) ? obj : shallowRef(obj)in:useModal/index.tsuseToast/index.tsusePopover/index.tsshallowRefonly tracks.valueassignment without making nested properties reactive, preventing components from becoming reactive objects.Small replication
https://stackblitz.com/edit/github-kpbciadc?file=src%2Fcomponents%2FComp.vue
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)feat(...)fix(...)docs(...)The PR fulfills these requirements:
CHANGELOGis generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be deniedOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.