Skip to content

Conversation

@xvaara
Copy link
Contributor

@xvaara xvaara commented Nov 21, 2024

Describe the PR

fixes #2365

Small replication

A small replication or video walkthrough can help demonstrate the changes made. This is optional, but can help observe the intended changes. A mentioned issue that contains a replication also works.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix 🐛 - fix(...)
  • Feature - feat(...)
  • ARIA accessibility - fix(...)
  • Documentation update - docs(...)
  • Other (please describe)

The PR fulfills these requirements:

  • Pull request title and all commits follow the Conventional Commits convention or has an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 21, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next@2367
pnpm add https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next/@bootstrap-vue-next/nuxt@2367

commit: c431ac1

VividLemon
VividLemon previously approved these changes Nov 21, 2024
@xvaara xvaara merged commit d8029c1 into bootstrap-vue-next:main Nov 21, 2024
1 of 3 checks passed
@xvaara xvaara deleted the fix-backdrop-flicker branch November 21, 2024 14:58
xvaara added a commit to xvaara/bootstrap-vue-next that referenced this pull request Nov 21, 2024
* upstream/main:
  Fix-backdrop-flicker (bootstrap-vue-next#2367)
  docs: Fix lint errors in Layout.vue + styling of otp (bootstrap-vue-next#2363)
  chore: release main (bootstrap-vue-next#2362)
  fix: useTemplateRef usage throwing errors fixes bootstrap-vue-next#2361
import {computed, type EmitFn, nextTick, onMounted, type Ref, ref, watch} from 'vue'
import {BvTriggerableEvent} from '../utils'
import {useEventListener} from '@vueuse/core'
import {useEventListener, useThrottleFn} from '@vueuse/core'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vueuse is amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: BModal's background is now "flashing" when the BModal opens

3 participants