Skip to content

Conversation

@dwgray
Copy link
Member

@dwgray dwgray commented Nov 20, 2024

Describe the PR

  • Fixed several 'new' lint errors in Layout.vue (possibly due to the recent upgrade of eslint)
  • The on this page formatting was being broken by the teleport when shown as an offfcanvas. I just pulled out the .table-of-contents styling from the otp-sidebar - we're only using table-of-contents in the one place, so it seemed the cleanest solution (and I suspect if we decide to do a TOC embedded elsewhere, we'd want these stylings anyway),

Small replication

View the docs in a small window.
Open the on this page overlay.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix 🐛 - fix(...)
  • Feature - feat(...)
  • ARIA accessibility - fix(...)
  • Documentation update - docs(...)
  • Other (please describe)

The PR fulfills these requirements:

  • Pull request title and all commits follow the Conventional Commits convention or has an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 20, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next@2363
pnpm add https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next/@bootstrap-vue-next/nuxt@2363

commit: facba34

@VividLemon VividLemon merged commit 04e1bdd into bootstrap-vue-next:main Nov 20, 2024
4 checks passed
xvaara added a commit to xvaara/bootstrap-vue-next that referenced this pull request Nov 21, 2024
* upstream/main:
  Fix-backdrop-flicker (bootstrap-vue-next#2367)
  docs: Fix lint errors in Layout.vue + styling of otp (bootstrap-vue-next#2363)
  chore: release main (bootstrap-vue-next#2362)
  fix: useTemplateRef usage throwing errors fixes bootstrap-vue-next#2361
@dwgray dwgray deleted the layout-cleanup branch December 9, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants