Skip to content

Conversation

@dwgray
Copy link
Member

@dwgray dwgray commented Oct 31, 2024

Describe the PR

As part of the parity pass, I went through and added notes for all not yet implemented or deprecated components. I errored towards marking things as NYI rather than deprecated. I don't think that any of the currently unimplemented components would necessarily block us from declaring a v1 (other than possibly the date/time related ones, which I believe @VividLemon is looking at now). Things like Jubotron, and Media, and PaginationNav can reasonably be worked around using straight bootstrap classes - if someone feels compelled to smooth things out by implementing BSVN components the wouldn't be breaking changes and could be added at any time, including after we declare the library production ready.

I'd be fine with drawing the line differently if @VividLemon or @xvaara has an opinion.

Small replication

N/A

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix 🐛 - fix(...)
  • Feature - feat(...)
  • ARIA accessibility - fix(...)
  • Documentation update - docs(...)
  • Other (please describe)

The PR fulfills these requirements:

  • Pull request title and all commits follow the Conventional Commits convention or has an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 31, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next@2319
pnpm add https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next/@bootstrap-vue-next/nuxt@2319

commit: 9e1c791

@VividLemon VividLemon merged commit 41dd9eb into bootstrap-vue-next:main Oct 31, 2024
4 checks passed
xvaara added a commit to xvaara/bootstrap-vue-next that referenced this pull request Nov 8, 2024
* upstream/main:
  chore: release main (bootstrap-vue-next#2327)
  fix(BTable): dynamic slots not rendering fixes bootstrap-vue-next#2328 (bootstrap-vue-next#2329)
  feat(BTable): make it possible to style custom footers (bootstrap-vue-next#2314)
  chore: release main (bootstrap-vue-next#2323)
  fix(BFormGroup): fix layout problem when label-for is not used (bootstrap-vue-next#2321)
  chore: release main (bootstrap-vue-next#2320)
  feat(BPagination): add small screen support (bootstrap-vue-next#2308)
  docs(BFormTextarea): Update auto height section + refactor (bootstrap-vue-next#2313)
  docs(migration): Document unimplemented components (bootstrap-vue-next#2319)
  docs: fix tables are not being formatted (bootstrap-vue-next#2317)
@dwgray dwgray deleted the nyi-components branch December 9, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants