fix(BFormCheckbox): indeterminate state fixes #2271 #2274
Conversation
|
|
commit: |
* upstream/main: chore: release main (bootstrap-vue-next#2275) fix(BFormCheckbox): indeterminate state not working properly fixes bootstrap-vue-next#2271 (bootstrap-vue-next#2274) chore: release main (bootstrap-vue-next#2270) fix(BModal): fix backdrop when modal is shown using v-if (bootstrap-vue-next#2269) chore: release main (bootstrap-vue-next#2259) fix(BFormInput): bad model modifier trim behavior fixes bootstrap-vue-next#2253 (bootstrap-vue-next#2267) fix(BModal): multiple modals backdrop fix (bootstrap-vue-next#2263) feat: clean deprecated classes and props from bootstrap (sr-only => visually-hidden) docs(BDropdown): Fill out component references for subcomponents (bootstrap-vue-next#2265) feat(BDropdown): add variant, classes and correct attrs to text sub components (bootstrap-vue-next#2258) fix(BModal): fix backdrop click prevention, fix flickering when no-fade (bootstrap-vue-next#2262) fix(BPopover): calculate mouse and element positions in a performant way (bootstrap-vue-next#2252)
|
@VividLemon is there a reason why you'd like to remove the indeterminate prop from dom? You should fix the tests also if this was the intent. |
It's not a dom attribute, it's a javascript psuedoclass |
|
TIL |
I feel like this is likely causing the test failure on #2276, but let me know if you think otherwise @VividLemon and I'll dig into it... |
Yes it is, we need to fix the tests. Just remove the failing tests, they are wrong :) indeterminate prop should not be in dom as the test expexts. |
* upstream/main: test: form checkbox indeterminate behavior (bootstrap-vue-next#2279) chore: release main (bootstrap-vue-next#2278) fix(BModal): remove scrolllock on unmount (bootstrap-vue-next#2277) chore: release main (bootstrap-vue-next#2275) fix(BFormCheckbox): indeterminate state not working properly fixes bootstrap-vue-next#2271 (bootstrap-vue-next#2274) chore: release main (bootstrap-vue-next#2270) fix(BModal): fix backdrop when modal is shown using v-if (bootstrap-vue-next#2269) chore: release main (bootstrap-vue-next#2259) fix(BFormInput): bad model modifier trim behavior fixes bootstrap-vue-next#2253 (bootstrap-vue-next#2267) fix(BModal): multiple modals backdrop fix (bootstrap-vue-next#2263) feat: clean deprecated classes and props from bootstrap (sr-only => visually-hidden) docs(BDropdown): Fill out component references for subcomponents (bootstrap-vue-next#2265) feat(BDropdown): add variant, classes and correct attrs to text sub components (bootstrap-vue-next#2258) fix(BModal): fix backdrop click prevention, fix flickering when no-fade (bootstrap-vue-next#2262)
3 participants
Describe the PR
A clear and concise description of what the pull request does.
Small replication
A small replication or video walkthrough can help demonstrate the changes made. This is optional, but can help observe the intended changes. A mentioned issue that contains a replication also works.
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)feat(...)fix(...)docs(...)The PR fulfills these requirements:
CHANGELOGis generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied