Skip to content

Conversation

@darthf1
Copy link
Contributor

@darthf1 darthf1 commented Sep 12, 2024

Describe the PR

Passes the exactActiveClass prop to the router component

Small replication

A small replication or video walkthrough can help demonstrate the changes made. This is optional, but can help observe the intended changes. A mentioned issue that contains a replication also works.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix 🐛 - fix(...)
  • Feature - feat(...)
  • ARIA accessibility - fix(...)
  • Documentation update - docs(...)
  • Other (please describe)

The PR fulfills these requirements:

  • Pull request title and all commits follow the Conventional Commits convention or has an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 12, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next@2188
pnpm add https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next/@bootstrap-vue-next/nuxt@2188

commit: 4dab11a

@xvaara xvaara merged commit f0b49fe into bootstrap-vue-next:main Sep 12, 2024
@github-actions github-actions bot mentioned this pull request Sep 12, 2024
@darthf1 darthf1 deleted the patch-2 branch September 12, 2024 21:39
xvaara added a commit to xvaara/bootstrap-vue-next that referenced this pull request Sep 17, 2024
* upstream/main:
  doc(variant): interaction between variant, bg-variant & text-variant (bootstrap-vue-next#2200)
  chore: release main (bootstrap-vue-next#2206)
  fix(ConditionalWrapper): don't inherit attrs (bootstrap-vue-next#2205)
  docs: fix paths (bootstrap-vue-next#2204)
  chore: release main (bootstrap-vue-next#2196)
  fix: change renderorskip to wrapper, add our own teleport logic. (bootstrap-vue-next#2162)
  fix(BTable): Type check failed for prop tbodyTrClass fixes bootstrap-vue-next#2197 (bootstrap-vue-next#2198)
  fix(resolver): resolver path for BCloseButton
  feat(BCarousel): add noAnimation prop (bootstrap-vue-next#2194)
  docs: Migration Guide refactor (bootstrap-vue-next#2186)
  chore: release main (bootstrap-vue-next#2191)
  fix(BNavItem): pass prop exactActiveClass to router component (bootstrap-vue-next#2188)
  chore: release main (bootstrap-vue-next#2190)
  fix: improper import path (bootstrap-vue-next#2189)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants