Skip to content

Conversation

@dwgray
Copy link
Member

@dwgray dwgray commented Sep 11, 2024

Describe the PR

  • Refactor the migration guide to put code into separate files
  • Add the idea of a code fragment in our markdown.it plug-in for where we're just displaying the sample code, not running the demo (useful for migration before/after among other things)
  • Make HighlightCard recognize when there isn't a running component, and don't add in the first BCardBody, which was just an annoying amount of blank space.
  • Generalize the configuration of the auto-resolver to grab *.vue files in any demo directory so samples can be in a demo directory directly adjacent to the *.md file in various places in our docs.

Small replication

A small replication or video walkthrough can help demonstrate the changes made. This is optional, but can help observe the intended changes. A mentioned issue that contains a replication also works.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix 🐛 - fix(...)
  • Feature - feat(...)
  • ARIA accessibility - fix(...)
  • Documentation update - docs(...)
  • Other (please describe)

The PR fulfills these requirements:

  • Pull request title and all commits follow the Conventional Commits convention or has an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@dwgray dwgray marked this pull request as ready for review September 11, 2024 22:10
@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 11, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next@2186
pnpm add https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next/@bootstrap-vue-next/nuxt@2186

commit: 4b66704

@VividLemon VividLemon merged commit f7aee13 into bootstrap-vue-next:main Sep 12, 2024
xvaara added a commit to xvaara/bootstrap-vue-next that referenced this pull request Sep 17, 2024
* upstream/main:
  doc(variant): interaction between variant, bg-variant & text-variant (bootstrap-vue-next#2200)
  chore: release main (bootstrap-vue-next#2206)
  fix(ConditionalWrapper): don't inherit attrs (bootstrap-vue-next#2205)
  docs: fix paths (bootstrap-vue-next#2204)
  chore: release main (bootstrap-vue-next#2196)
  fix: change renderorskip to wrapper, add our own teleport logic. (bootstrap-vue-next#2162)
  fix(BTable): Type check failed for prop tbodyTrClass fixes bootstrap-vue-next#2197 (bootstrap-vue-next#2198)
  fix(resolver): resolver path for BCloseButton
  feat(BCarousel): add noAnimation prop (bootstrap-vue-next#2194)
  docs: Migration Guide refactor (bootstrap-vue-next#2186)
  chore: release main (bootstrap-vue-next#2191)
  fix(BNavItem): pass prop exactActiveClass to router component (bootstrap-vue-next#2188)
  chore: release main (bootstrap-vue-next#2190)
  fix: improper import path (bootstrap-vue-next#2189)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants