fix(BPagination): hide-goto-end doesn't hide first-page or last-page #2171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
commit: |
6 tasks
VividLemon
approved these changes
Sep 4, 2024
Merged
xvaara
added a commit
to xvaara/bootstrap-vue-next
that referenced
this pull request
Sep 11, 2024
* upstream/main: (179 commits) chore: release main (bootstrap-vue-next#2175) docs(BImg): Parity pass (bootstrap-vue-next#2177) docs: Use Not Yet Implemented Component consistently (bootstrap-vue-next#2183) docs(BCarousel): Parity pass (bootstrap-vue-next#2179) feat(BCarousel): add click:prev and click:next events refactor: reduce module packages complexity refactor: make define models use component imported prop type fix directives on element update during interaction (bootstrap-vue-next#2170) fix(BTabs): fix recursion on titleLinkAttrs (bootstrap-vue-next#2169) chore: release main (bootstrap-vue-next#2172) fix(BPagination): hide-goto-end doesn't hide firstPage or lastPage (bootstrap-vue-next#2171) Update vite template for bugs to work now that it seems we don't import components docs(BCard): Parity pass (bootstrap-vue-next#2168) docs(BPagination): Update Component refs & clean up documentation (bootstrap-vue-next#2152) Delete .github/workflows/pkg-pr-new.yaml Update ci.yaml with pkg.pr.new add pkg.pr.new to publish a package for each commit and pull request chore: release main (bootstrap-vue-next#2149) fix(BPagination): Get rid of bad binding on li (bootstrap-vue-next#2150) fix: pass attributes through in BDropdownItemButton (bootstrap-vue-next#2143) ...
xvaara
added a commit
to xvaara/bootstrap-vue-next
that referenced
this pull request
Sep 11, 2024
* upstream/main: chore: release main (bootstrap-vue-next#2175) docs(BImg): Parity pass (bootstrap-vue-next#2177) docs: Use Not Yet Implemented Component consistently (bootstrap-vue-next#2183) docs(BCarousel): Parity pass (bootstrap-vue-next#2179) feat(BCarousel): add click:prev and click:next events refactor: reduce module packages complexity refactor: make define models use component imported prop type fix directives on element update during interaction (bootstrap-vue-next#2170) fix(BTabs): fix recursion on titleLinkAttrs (bootstrap-vue-next#2169) chore: release main (bootstrap-vue-next#2172) fix(BPagination): hide-goto-end doesn't hide firstPage or lastPage (bootstrap-vue-next#2171) Update vite template for bugs to work now that it seems we don't import components docs(BCard): Parity pass (bootstrap-vue-next#2168) docs(BPagination): Update Component refs & clean up documentation (bootstrap-vue-next#2152) Delete .github/workflows/pkg-pr-new.yaml Update ci.yaml with pkg.pr.new
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
This PR addresses #2165
I misunderstood the intention of the
hide-goto-end-buttonsflag. It should just hide the explicitfirstandlastbuttons, not the first page or last page button (which are labeled with the page numbers). That is how BSV works and it seems reasonable so I've reimplemented it that way.I also discovered an issue that was either because of the refactor I recently did or a change in how vue handles keys in a for loop. In either case, having a duplicate key in the array for the ellipsis causes some weird update problems (at lest in dev mode) so I removed that ambiguity while I was at it.
Small replication
See #2165
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)feat(...)fix(...)docs(...)The PR fulfills these requirements:
CHANGELOGis generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied