change renderorskip to wrapper, add our own teleport logic. #2162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
commit: |
6 tasks
VividLemon
requested changes
Sep 5, 2024
packages/bootstrap-vue-next/src/components/BFormCheckbox/BFormCheckbox.vue
Outdated
Show resolved
Hide resolved
…Checkbox.vue Co-authored-by: Issayah <[email protected]>
* upstream/main: chore: release main (bootstrap-vue-next#2175) docs(BImg): Parity pass (bootstrap-vue-next#2177) docs: Use Not Yet Implemented Component consistently (bootstrap-vue-next#2183) docs(BCarousel): Parity pass (bootstrap-vue-next#2179) feat(BCarousel): add click:prev and click:next events refactor: reduce module packages complexity refactor: make define models use component imported prop type fix directives on element update during interaction (bootstrap-vue-next#2170) fix(BTabs): fix recursion on titleLinkAttrs (bootstrap-vue-next#2169) chore: release main (bootstrap-vue-next#2172) fix(BPagination): hide-goto-end doesn't hide firstPage or lastPage (bootstrap-vue-next#2171) Update vite template for bugs to work now that it seems we don't import components docs(BCard): Parity pass (bootstrap-vue-next#2168) docs(BPagination): Update Component refs & clean up documentation (bootstrap-vue-next#2152) Delete .github/workflows/pkg-pr-new.yaml Update ci.yaml with pkg.pr.new
VividLemon
requested changes
Sep 12, 2024
packages/bootstrap-vue-next/src/components/BDropdown/BDropdown.vue
Outdated
Show resolved
Hide resolved
packages/bootstrap-vue-next/src/components/BFormRadio/BFormRadio.vue
Outdated
Show resolved
Hide resolved
VividLemon
reviewed
Sep 14, 2024
packages/bootstrap-vue-next/src/components/BOffcanvas/BOffcanvas.vue
Outdated
Show resolved
Hide resolved
VividLemon
reviewed
Sep 14, 2024
packages/bootstrap-vue-next/src/components/BDropdown/BDropdown.vue
Outdated
Show resolved
Hide resolved
packages/bootstrap-vue-next/src/components/BModal/BModalOrchestrator.vue
Outdated
Show resolved
Hide resolved
packages/bootstrap-vue-next/src/components/BPopover/BPopover.vue
Outdated
Show resolved
Hide resolved
packages/bootstrap-vue-next/src/components/BToast/BToastOrchestrator.vue
Outdated
Show resolved
Hide resolved
VividLemon
approved these changes
Sep 14, 2024
Merged
xvaara
added a commit
to xvaara/bootstrap-vue-next
that referenced
this pull request
Sep 17, 2024
* upstream/main: doc(variant): interaction between variant, bg-variant & text-variant (bootstrap-vue-next#2200) chore: release main (bootstrap-vue-next#2206) fix(ConditionalWrapper): don't inherit attrs (bootstrap-vue-next#2205) docs: fix paths (bootstrap-vue-next#2204) chore: release main (bootstrap-vue-next#2196) fix: change renderorskip to wrapper, add our own teleport logic. (bootstrap-vue-next#2162) fix(BTable): Type check failed for prop tbodyTrClass fixes bootstrap-vue-next#2197 (bootstrap-vue-next#2198) fix(resolver): resolver path for BCloseButton feat(BCarousel): add noAnimation prop (bootstrap-vue-next#2194) docs: Migration Guide refactor (bootstrap-vue-next#2186) chore: release main (bootstrap-vue-next#2191) fix(BNavItem): pass prop exactActiveClass to router component (bootstrap-vue-next#2188) chore: release main (bootstrap-vue-next#2190) fix: improper import path (bootstrap-vue-next#2189)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
This fixes the teleport problems are having. It seems upstream isn't interested in fixing this any time soon.
Renamed render or skip to BWrapper.
closes #1972
closes #2157
closes #1936
closes #2024
closes #2046
maybe even more
Small replication
A small replication or video walkthrough can help demonstrate the changes made. This is optional, but can help observe the intended changes. A mentioned issue that contains a replication also works.
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)feat(...)fix(...)docs(...)The PR fulfills these requirements:
CHANGELOGis generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied