Skip to content

Conversation

@dwgray
Copy link
Member

@dwgray dwgray commented Aug 27, 2024

Describe the PR

This is the parity pass for the BPagination component

  • Went through docs and cleaned them up
  • Refactored examples into the demo directory
  • Updated types
  • Update migration guide
  • Updated the parity spreadsheet
  • Added bugs for missing features

Small replication

N/A

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix 🐛 - fix(...)
  • Feature - feat(...)
  • ARIA accessibility - fix(...)
  • Documentation update - docs(...)
  • Other (please describe)

The PR fulfills these requirements:

  • Pull request title and all commits follow the Conventional Commits convention or has an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@dwgray dwgray marked this pull request as draft August 27, 2024 21:42
@dwgray dwgray force-pushed the pagination-parity branch from f163095 to 9c59097 Compare August 27, 2024 22:11
@dwgray dwgray marked this pull request as ready for review August 28, 2024 23:44
@VividLemon VividLemon merged commit fea1afb into bootstrap-vue-next:main Aug 30, 2024
@dwgray dwgray deleted the pagination-parity branch September 10, 2024 15:53
xvaara added a commit to xvaara/bootstrap-vue-next that referenced this pull request Sep 11, 2024
* upstream/main: (179 commits)
  chore: release main (bootstrap-vue-next#2175)
  docs(BImg): Parity pass (bootstrap-vue-next#2177)
  docs: Use Not Yet Implemented Component consistently (bootstrap-vue-next#2183)
  docs(BCarousel): Parity pass (bootstrap-vue-next#2179)
  feat(BCarousel): add click:prev and click:next events
  refactor: reduce module packages complexity
  refactor: make define models use component imported prop type
  fix directives on element update during interaction (bootstrap-vue-next#2170)
  fix(BTabs): fix recursion on titleLinkAttrs (bootstrap-vue-next#2169)
  chore: release main (bootstrap-vue-next#2172)
  fix(BPagination): hide-goto-end doesn't hide firstPage or lastPage (bootstrap-vue-next#2171)
  Update vite template for bugs to work now that it seems we don't import components
  docs(BCard): Parity pass (bootstrap-vue-next#2168)
  docs(BPagination): Update Component refs & clean up documentation (bootstrap-vue-next#2152)
  Delete .github/workflows/pkg-pr-new.yaml
  Update ci.yaml with pkg.pr.new
  add pkg.pr.new to publish a package for each commit and pull request
  chore: release main (bootstrap-vue-next#2149)
  fix(BPagination): Get rid of bad binding on li (bootstrap-vue-next#2150)
  fix: pass attributes through in BDropdownItemButton (bootstrap-vue-next#2143)
  ...
xvaara added a commit to xvaara/bootstrap-vue-next that referenced this pull request Sep 11, 2024
* upstream/main:
  chore: release main (bootstrap-vue-next#2175)
  docs(BImg): Parity pass (bootstrap-vue-next#2177)
  docs: Use Not Yet Implemented Component consistently (bootstrap-vue-next#2183)
  docs(BCarousel): Parity pass (bootstrap-vue-next#2179)
  feat(BCarousel): add click:prev and click:next events
  refactor: reduce module packages complexity
  refactor: make define models use component imported prop type
  fix directives on element update during interaction (bootstrap-vue-next#2170)
  fix(BTabs): fix recursion on titleLinkAttrs (bootstrap-vue-next#2169)
  chore: release main (bootstrap-vue-next#2172)
  fix(BPagination): hide-goto-end doesn't hide firstPage or lastPage (bootstrap-vue-next#2171)
  Update vite template for bugs to work now that it seems we don't import components
  docs(BCard): Parity pass (bootstrap-vue-next#2168)
  docs(BPagination): Update Component refs & clean up documentation (bootstrap-vue-next#2152)
  Delete .github/workflows/pkg-pr-new.yaml
  Update ci.yaml with pkg.pr.new
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants