Skip to content

Conversation

@xvaara
Copy link
Contributor

@xvaara xvaara commented Apr 16, 2024

Describe the PR

fixes #1846

BEGIN_COMMIT_OVERRIDE
fix: Some prop types were build wrong because of vue bug
END_COMMIT_OVERRIDE

Small replication

A small replication or video walkthrough can help demonstrate the changes made. This is optional, but can help observe the intended changes. A mentioned issue that contains a replication also works.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix 🐛 - fix(...)
  • Feature - feat(...)
  • ARIA accessibility - fix(...)
  • Documentation update - docs(...)
  • Other (please describe)

The PR fulfills these requirements:

  • Pull request title and all commits follow the Conventional Commits convention or has an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@xvaara xvaara merged commit 3459a54 into bootstrap-vue-next:main Apr 16, 2024
xvaara added a commit to xvaara/bootstrap-vue-next that referenced this pull request Apr 17, 2024
* upstream/main:
  update vue deps (bootstrap-vue-next#1850)
  fix(BPopover): fix injection out of setup context. (bootstrap-vue-next#1848)
  ci: add workflow dispatch to docs deploy
  chore: release main
  fix(BFormCheckbox): Prevent empty string being cast to true fixes bootstrap-vue-next#1822
  feat(utils): inject getId to allow for custom id generation (bootstrap-vue-next#1836)
  BTable multisort (bootstrap-vue-next#1842)
  fix(BFormSelect): array of numbers or dates (bootstrap-vue-next#1839)
  fix(BPopover and Btooltip): Fixes bootstrap-vue-next#1232 - do not create a new app fro each tooltip or popover (bootstrap-vue-next#1837)
@xvaara xvaara deleted the dep-up branch April 25, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vue core issue tracker Vue warns of a type check failure

2 participants