Compiler to main.css #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 13, 2022
justinkruit
approved these changes
Feb 14, 2022
Member
justinkruit
left a comment
justinkruit
left a comment
There was a problem hiding this comment.
All looks good. I honestly prefer this change, with the css and scss folders being separate.
crftwrk
added a commit
to bootscore/bootscore-child
that referenced
this pull request
Feb 14, 2022
crftwrk
added a commit
to bootscore/bootcommerce-child
that referenced
this pull request
Feb 14, 2022
kentarcher28
added a commit
to kentarcher28/Wordpress-bootst-child
that referenced
this pull request
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the compiled output to
css/main.css. Previous naming and foldercss/lib/bootstrap.min.cssis outdated because file contains now all css. Thescssfolder is in theme root now.This does not bring any technical benefit in the frontend, but it helps us to organise scss files and sets compiled output in a logical way.
PR's to enque file in child-themes
Tested and works fine.
@justinkruit if you agree with this, I'm happy when you press the merge button. You do not have to review all files, because they only moved. Just a quick view to
scss-compiler.phpand enque script infunctions.phpwould be nice. Thank you.