aria-label for hamburger menù #936
Conversation
aria-label for hamburger icon
update version to 6.0.5
|
Thank you, this is a good idea! If we do that, we should add the Want to add them? |
aria-label for search toggler
aria-label for close button
Fixed aria-label for search button not correct insert
Update bootscore version
Update aria-label and Bootscore version
Fixed aria-label escape with esc_attr_e
Added aria-label for search input and search submit button. Fixed esc_attr_e for placeholder.
Updated to 6.1.0
Updated to 6.1.0
Updated to 6.1.0
Updated to 6.1.0
|
Updated, check if new escape method is correct. I think is more codex style. If you remember other accessibility points, tell me :) Best regards |
Fix for issues 442/934 Pull 757 Fix TinyMCE editor body margin and font-family that is overridden by Bootstrap editor-styles.
Fix TinyMCE editor body margin and font-family that is overridden by Bootstrap editor-styles, added the new require for tinymce-editor.php.
|
Next release will be on Feb. 24 alongside the WooCommerce 9.7 update. Not sure if we are ready to ship v6.1 until there. So version 6.0.5 is more safe. |
Revert to 6.0.5 release
Revert to 6.0.5 release
Revert to 6.0.5 release
Revert to 6.0.5 release
Revert to 6.0.5 release
Revert to 6.0.5 release
|
Revert to 6.0.5 release :) |
header.php
Outdated
|
|
||
| <!-- Navbar Toggler --> | ||
| <button class="<?= apply_filters('bootscore/class/header/button', 'btn btn-outline-secondary', 'nav-toggler'); ?> <?= apply_filters('bootscore/class/header/navbar/toggler/breakpoint', 'd-lg-none'); ?> ms-1 ms-md-2 nav-toggler" type="button" data-bs-toggle="offcanvas" data-bs-target="#offcanvas-navbar" aria-controls="offcanvas-navbar"> | ||
| <button class="<?= apply_filters('bootscore/class/header/button', 'btn btn-outline-secondary', 'nav-toggler'); ?> <?= apply_filters('bootscore/class/header/navbar/toggler/breakpoint', 'd-lg-none'); ?> ms-1 ms-md-2 nav-toggler" type="button" data-bs-toggle="offcanvas" data-bs-target="#offcanvas-navbar" aria-controls="offcanvas-navbar" aria-label="<?php esc_html_e( 'Toggle main menu', 'bootscore' ); ?>> |
There was a problem hiding this comment.
Why using esc_html_ehere while others uses esc_attr_e?
Fixed with esc_attr_e for menu aria-label.
crftwrk
left a comment
crftwrk
left a comment
There was a problem hiding this comment.
Thank you 🙏. Just fixed missing close " in header.php
2 participants
aria-label for hamburger menù
Closes #934