Move assets to assets folder #682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crftwrk
approved these changes
Feb 16, 2024
Member
crftwrk
left a comment
crftwrk
left a comment
There was a problem hiding this comment.
Looks good. Before merging, I did the same for the child bootscore/bootscore-child#41. May have a quick look?
crftwrk
requested changes
Feb 16, 2024
Member
crftwrk
left a comment
crftwrk
left a comment
There was a problem hiding this comment.
Found a bug that source map is not linked correct in compiled CSS:
/*# sourceMappingURL=/wp-content/themes/bootscore-child-dev-main/assets/css/main.map */
bootscore/inc/scss-compiler.php
Line 54 in e4e2e27
'map' should be replaced by 'css.map'?
Member
Author
Good catch! Fixed it in abe3d9d |
crftwrk
approved these changes
Feb 16, 2024
Member
crftwrk
left a comment
crftwrk
left a comment
There was a problem hiding this comment.
Great, may have a quick view to the child's assets folder bootscore/bootscore-child#41?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will move CSS, SCSS, JS, img and FontAwesome to a separate assets folder. This will help keep the folder structure cleaner.
As a small extra I've also renamed the .map file of the css to be main.css.map instead of main.map. This is in line with how it should be saved and is preferred by IDEs.
This PR closes #669