Revert https://github.com/bootscore/bootscore/pull/909 #1029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I told you you'd do it faster and better ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pro-wow 👀
This PR downgrades scssphp back to v1. Maybe it was too sophisticated for now, we do the update to scssphp v2 in Bootscore v7 which comes with Bootsrtap v6.
But there are some bugs on your site:
style.css. I've readded the header, but you have done your styles instyle.csswhich is wrong. Keep this file untouched and do all styles in_bootscore-custom.scssas described here https://bootscore.me/documentation/theme/css-scss-compiler/#bootscore-custom-scss. No additional tasks required, just do stuff here.Please download https://github.com/bootscore/bootscore/tree/Revert-https/github.com/bootscore/bootscore/pull/909, unzip, rename folder to bootscore and zip. Please test this on several sites. If this is fine, I will merge this PR in te middle of the week.