ostree-ext: reuse prior packing with exclusive components#2109
Draft
officialasishkumar wants to merge 1 commit intobootc-dev:mainfrom
Draft
ostree-ext: reuse prior packing with exclusive components#2109officialasishkumar wants to merge 1 commit intobootc-dev:mainfrom
officialasishkumar wants to merge 1 commit intobootc-dev:mainfrom
Conversation
Signed-off-by: Asish Kumar <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request modifies the basic_packing_with_prior_build function in crates/ostree-ext/src/chunking.rs to correctly handle exclusive-component bins. It introduces logic to filter out empty bins from the prior build while ensuring the final reserved bin for new packages is preserved. Additionally, the bin size validation check has been moved to execute after this filtering process. A new test case, test_advanced_packing_with_prior_exclusive_components, was added to verify that the prior layout remains reusable after exclusive bins are removed. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reuse the prior-build packing layout when exclusive components have already been split into dedicated layers.
Changes
Testing
cargo fmt --check --alldocker run --rm -v /home/ashish/asish_workspace/personal/bootc:/src -w /src fedora:42 bash -lc 'set -euo pipefail && dnf -y install rust cargo pkgconf-pkg-config glib2-devel ostree-devel openssl-devel systemd-devel libzstd-devel git gcc make && cargo test -p ostree-ext test_advanced_packing -- --nocapture && cargo test -p ostree-ext test_exclusive_chunks -- --nocapture'Fixes #2057