Goroutine data race #195
Description
Describe the bug
A data race exists in the analyze_org sub-command, specifically in `Inventory.AddPackage1.
Line 43 in e259b09
$ ./poutine analyze_org $ORG --token="..."
WARNING: DATA RACE
Write at 0x00c00007c0f0 by goroutine 629:
github.com/boostsecurityio/poutine/scanner.(*Inventory).AddPackage()
/tmp/poutine/scanner/inventory.go:43 +0x2a4
github.com/boostsecurityio/poutine/analyze.(*Analyzer).AnalyzeOrg.func1()
/tmp/poutine/analyze/analyze.go:138 +0x45c
github.com/boostsecurityio/poutine/analyze.(*Analyzer).AnalyzeOrg.gowrap1()
/tmp/poutine/analyze/analyze.go:144 +0x4f
Previous read at 0x00c00007c0f0 by goroutine 640:
github.com/boostsecurityio/poutine/scanner.(*Inventory).AddPackage()
/tmp/poutine/scanner/inventory.go:43 +0x1f6
github.com/boostsecurityio/poutine/analyze.(*Analyzer).AnalyzeOrg.func1()
/tmp/poutine/analyze/analyze.go:138 +0x45c
github.com/boostsecurityio/poutine/analyze.(*Analyzer).AnalyzeOrg.gowrap1()
/tmp/poutine/analyze/analyze.go:144 +0x4f
Goroutine 629 (running) created at:
github.com/boostsecurityio/poutine/analyze.(*Analyzer).AnalyzeOrg()
/tmp/poutine/analyze/analyze.go:121 +0xec4
github.com/boostsecurityio/poutine/cmd.init.func2()
/tmp/poutine/cmd/analyzeOrg.go:34 +0x164
github.com/spf13/cobra.(*Command).execute()
/home/user/go/pkg/mod/github.com/spf13/[email protected]/command.go:985 +0x10f3
github.com/spf13/cobra.(*Command).ExecuteC()
/home/user/go/pkg/mod/github.com/spf13/[email protected]/command.go:1117 +0x657
github.com/spf13/cobra.(*Command).Execute()
/home/user/go/pkg/mod/github.com/spf13/[email protected]/command.go:1041 +0x319
github.com/spf13/cobra.(*Command).ExecuteContext()
/home/user/go/pkg/mod/github.com/spf13/[email protected]/command.go:1034 +0x314
github.com/boostsecurityio/poutine/cmd.Execute()
/tmp/poutine/cmd/root.go:89 +0x2a5
main.main()
/tmp/poutine/poutine.go:17 +0x165
Goroutine 640 (running) created at:
github.com/boostsecurityio/poutine/analyze.(*Analyzer).AnalyzeOrg()
/tmp/poutine/analyze/analyze.go:121 +0xec4
github.com/boostsecurityio/poutine/cmd.init.func2()
/tmp/poutine/cmd/analyzeOrg.go:34 +0x164
github.com/spf13/cobra.(*Command).execute()
/home/user/go/pkg/mod/github.com/spf13/[email protected]/command.go:985 +0x10f3
github.com/spf13/cobra.(*Command).ExecuteC()
/home/user/go/pkg/mod/github.com/spf13/[email protected]/command.go:1117 +0x657
github.com/spf13/cobra.(*Command).Execute()
/home/user/go/pkg/mod/github.com/spf13/[email protected]/command.go:1041 +0x319
github.com/spf13/cobra.(*Command).ExecuteContext()
/home/user/go/pkg/mod/github.com/spf13/[email protected]/command.go:1034 +0x314
github.com/boostsecurityio/poutine/cmd.Execute()
/tmp/poutine/cmd/root.go:89 +0x2a5
main.main()
/tmp/poutine/poutine.go:17 +0x165
Found 1 data race(s)To Reproduce
- Build poutine using the
-raceflag:go build -race - Run poutine with
analyze_orgagainst an org with a few repositories and findings. - Observe a race.
Expected Behaviour
The call should be protected by a mutex