Fix linting issues: gofmt formatting and testifylint violations

Copilot · fproulx-boostsecurity · Copilot · commit 59526f74ede3 · 2025-10-09T16:25:26.000Z
- Remove trailing whitespace in cmd/handle_analyze_manifest_test.go and cmd/mcp_server.go
- Replace assert.Len(t, ..., 0, ...) with assert.Empty(t, ...) for testifylint compliance
- All tests still pass and functionality remains intact

Co-authored-by: fproulx-boostsecurity &lt;76956526+fproulx-boostsecurity@users.noreply.github.com&gt;
diff --git a/cmd/handle_analyze_manifest_test.go b/cmd/handle_analyze_manifest_test.go
@@ -340,7 +340,7 @@ jobs:
 
 		// Should have multiple findings including injection
 		assert.Greater(t, len(insights.Findings), 1, "Should have multiple findings without filter")
-		
+
 		// Verify injection rule is present
 		hasInjection := false
 		for _, finding := range insights.Findings {
@@ -379,7 +379,7 @@ jobs:
 		// Should have only injection finding
 		assert.Len(t, insights.Findings, 1, "Should have only one finding with filter")
 		assert.Equal(t, "injection", insights.Findings[0].RuleId, "Should only have injection finding")
-		
+
 		// Should have only injection rule
 		assert.Len(t, insights.Rules, 1, "Should have only one rule with filter")
 		_, hasInjectionRule := insights.Rules["injection"]
@@ -411,8 +411,8 @@ jobs:
 		require.NoError(t, err)
 
 		// Should have no findings
-		assert.Len(t, insights.Findings, 0, "Should have no findings with non-existent rule filter")
-		assert.Len(t, insights.Rules, 0, "Should have no rules with non-existent rule filter")
+		assert.Empty(t, insights.Findings, "Should have no findings with non-existent rule filter")
+		assert.Empty(t, insights.Rules, "Should have no rules with non-existent rule filter")
 
 		t.Logf("Found %d findings with non-existent rule filter", len(insights.Findings))
 	})
diff --git a/cmd/mcp_server.go b/cmd/mcp_server.go
@@ -513,12 +513,12 @@ func handleAnalyzeManifest(ctx context.Context, request mcp.CallToolRequest, ana
 	if len(allowedRulesParam) > 0 {
 		requestConfig := *config
 		requestConfig.AllowedRules = allowedRulesParam
-		
+
 		requestOpaClient, err := newOpaWithConfig(ctx, &requestConfig)
 		if err != nil {
 			return mcp.NewToolResultError(fmt.Sprintf("failed to create OPA client with allowed rules: %v", err)), nil
 		}
-		
+
 		requestAnalyzer = analyze.NewAnalyzer(nil, nil, &noop.Format{}, &requestConfig, requestOpaClient)
 	} else {
 		requestAnalyzer = analyzer
