Skip to content

Fix windows builds that don't include Windows.h #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
klemens-morgenstern merged 2 commits into from
Oct 29, 2020
Merged

Fix windows builds that don't include Windows.h #171

klemens-morgenstern merged 2 commits into from
Oct 29, 2020

Conversation

@Shauren
Copy link
Contributor

@Shauren Shauren commented Sep 3, 2020 •
edited
Loading

Removed __kernel_entry usage from Nt* function typedefs, is is part of SAL annoations, not neccessary for proper signature and calling convention

Replaced global DWORD with ::boost::winapi::DWORD_

Also should fix #96 (not verified, I use msvc, not mingw but error appears on the same line)

@klemens-morgenstern
Copy link
Collaborator

klemens-morgenstern commented Sep 21, 2020

What version of MSVC are you using? I ran into issues with MSVC which is why I added the annotations.

@Shauren
Copy link
Contributor Author

Shauren commented Sep 22, 2020

Microsoft Visual Studio Community 2019
Version 16.7.3
v142 toolset
Microsoft (R) C/C++ Optimizing Compiler Version 19.27.29111 for x64

@Shauren
Copy link
Contributor Author

Shauren commented Sep 22, 2020 •
edited
Loading

I'll also add that __kernel_entry usage only causes issues with boost 1.73 and newer, because of this change in boost/winapi boostorg/winapi@c523cc4

Here is a part of /showIncludes trace with older version

Note: including file: C:/data/libraries/installed/x64-windows/include\boost/process/args.hpp
...
Note: including file:    C:/data/libraries/installed/x64-windows/include\boost/winapi/get_last_error.hpp
Note: including file:     C:/data/libraries/installed/x64-windows/include\boost/winapi/basic_types.hpp
...
Note: including file:      C:/WinSdk/Include/10.0.18362.0/shared\winerror.h
Note: including file:       C:/WinSdk/Include/10.0.18362.0/shared\specstrings.h
Note: including file:        C:/WinSdk/Include/10.0.18362.0/shared\specstrings_strict.h
Note: including file:         C:/WinSdk/Include/10.0.18362.0/shared\specstrings_undef.h

specstrings is where that define lives

@p13l13d13
Copy link

p13l13d13 commented Oct 23, 2020

@klemens-morgenstern any updates on this? I can confirm that this PR fixes the issue on latest MSVC:

Microsoft (R) C/C++ Optimizing Compiler Version 19.27.29112 for x86

from Visual Studio 2019 16.7.

@klemens-morgenstern klemens-morgenstern merged commit ee983eb into boostorg:develop Oct 29, 2020
@Shauren Shauren deleted the fix-windows-h branch October 30, 2020 17:26
@hebasto hebasto mentioned this pull request Jul 27, 2022
Merged
@soliton- soliton- mentioned this pull request Oct 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

boost v1.71 - Program fails to compile after including header : <boost/process.hpp>

3 participants

@Shauren @klemens-morgenstern @p13l13d13