Skip to content

Move pagination plugin to core#1992

Merged
ricardograca merged 5 commits into
masterfrom
rg-core-pagination
Jul 15, 2019
Merged

Move pagination plugin to core#1992
ricardograca merged 5 commits into
masterfrom
rg-core-pagination

Conversation

@ricardograca

Copy link
Copy Markdown
Member

Introduction

Move the pagination plugin to core Bookshelf.

Motivation

This is a very useful plugin and its functionality should be part of core since it's almost always used and, in fact, even the documentation has .fetchPage() as a Model method, even though it's currently only available if you call .plugin('pagination').

Proposed solution

Base functionality is moved to the lib/helpers.js file so it can be shared between model and collection methods. New fetchPage methods are added to Model and Collection. No functionality was removed.

@ricardograca
ricardograca merged commit b89331c into master Jul 15, 2019
@ricardograca
ricardograca deleted the rg-core-pagination branch July 15, 2019 21:38
@ricardograca ricardograca mentioned this pull request Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant