Fix incorrect output ordering in tests in some cases#1825
Merged
Conversation
- This ensures that the order of results returned by the database doesn't affect tests that are comparing them to pre-defined values with a certain order.
MonkeyDo
added a commit
to metabrainz/bookbrainz-data-js
that referenced
this pull request
Oct 25, 2019
In tests mostly but also for author credits. See bookshelf/bookshelf#1825
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
This ensures that output from database tests are ordered by model id.
Motivation
Some tests require that the output is exactly the same as some predefined values. However, the previous PR mentioned above introduced a change that caused output ordering to be changed on PostgreSQL, even though the data is exactly the same.
There shouldn't be any need to check for ordering of results unless that is the intended purpose of a specific test.
Fixes #426.
Proposed solution
This just orders models inside collections by id after they are fetched from the database. This application side approach was chosen to avoid changing all the affected tests.