Fix timestamps set with Invalid Date in some cases#1796
Merged
Conversation
- This fixes the issue of timestamp attributes being set to Invalid Date if the associated columns were ommitted in a fetch call.
ricardograca
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
The previous PR introduced a bug that led to the timestamp attributes sometimes being set with a
Invalid Datevalue.This only happened if a model with
hasTimestampsset totrueor an array was being fetched but the associated timestamp columns were omitted in thefetchcall using thecolumns: [ ... ]option.Strangely this also affected all calls of
fetchPagecausingnullor missing values forrowCountandpageCount.Proposed solution
This just checks if the relevant timestamp attributes return a truthy value before attempting to cast them to a
Dateobject.