Fixes Model fetchAll event documentation#1114
Merged
Merged
Conversation
…etched:collection` events
Contributor
|
Hey, I added a comment over at bookshelf/bookshelf-jsdoc-theme#3. Sorry for the late response. |
Member
|
I'm going to merge this because even with the default JSDoc theme the quotes break things. This change will require a new version of our own jsdoc theme. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
fetching:collectionandfetched:collectionevent tags have the event name wrapped in quotes. This is causing an issue in JSDoc which is preventing these events from being rendered in the menu and in the event detail blocks. This fixes that by removing the quotes and updating the JSDoc theme to use a more accurate regular expression for simplifying event names (bookshelf/bookshelf-jsdoc-theme#3).