What went wrong?
The Aladin provider's search() sends ISBN queries to ItemSearch.aspx as a keyword (QueryType: 'Keyword', server/src/modules/metadata-fetch/providers/aladin/aladin.provider.ts). This endpoint misses a significant portion of valid Korean ISBNs that the same API's ItemLookUp.aspx (with ItemIdType=ISBN13) returns reliably.
| ISBN |
ItemSearch |
ItemLookUp (ISBN13) |
9788984458314 |
0 results |
1 result |
9791155361849 |
0 results |
1 result |
9791165340582 |
0 results |
1 result |
9791192372754 |
0 results (wrong book) |
1 result (correct) |
Across 224 Korean ISBNs, ItemLookUp found 214 that ItemSearch missed (~95%+ vs ~71% hit rate).
Steps to reproduce
- Fetch metadata for a Korean book by ISBN (e.g.
9788984458314) with Aladin enabled.
- Aladin returns 0 candidates, even though the book exists in Aladin.
Expected vs actual behavior
Expected: When an ISBN is provided, the provider queries the ISBN-specific endpoint (ItemLookUp.aspx + ItemIdType=ISBN13, falling back to ISBN for 10-digit), and returns the matching book. This mirrors the pattern already used by the Goodreads provider, which prefers /book/isbn/{isbn} over keyword search when an ISBN is available (server/src/modules/metadata-fetch/providers/goodreads/goodreads.provider.ts).
Actual: The ISBN is sent as a keyword to ItemSearch.aspx, returning 0 results for ~24% of valid Korean ISBNs.
Your setup
- BookOrbit version: latest (
main)
- Collection: ~900 Korean titles
Before submitting
What went wrong?
The Aladin provider's
search()sends ISBN queries toItemSearch.aspxas a keyword (QueryType: 'Keyword',server/src/modules/metadata-fetch/providers/aladin/aladin.provider.ts). This endpoint misses a significant portion of valid Korean ISBNs that the same API'sItemLookUp.aspx(withItemIdType=ISBN13) returns reliably.ItemSearchItemLookUp(ISBN13)9788984458314979115536184997911653405829791192372754Across 224 Korean ISBNs,
ItemLookUpfound 214 thatItemSearchmissed (~95%+ vs ~71% hit rate).Steps to reproduce
9788984458314) with Aladin enabled.Expected vs actual behavior
Expected: When an ISBN is provided, the provider queries the ISBN-specific endpoint (
ItemLookUp.aspx+ItemIdType=ISBN13, falling back toISBNfor 10-digit), and returns the matching book. This mirrors the pattern already used by the Goodreads provider, which prefers/book/isbn/{isbn}over keyword search when an ISBN is available (server/src/modules/metadata-fetch/providers/goodreads/goodreads.provider.ts).Actual: The ISBN is sent as a keyword to
ItemSearch.aspx, returning 0 results for ~24% of valid Korean ISBNs.Your setup
main)Before submitting